add socket tier 1 reachability analysis - #550
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to run Socket “full application reachability” (Tier 1) analysis on this Rust workspace on a weekly schedule and via manual dispatch, surfacing Tier-2 fallback situations as a GitHub Actions warning without failing the job.
Changes:
- Introduces a new scheduled + on-demand workflow to run
socket scan create --reachagainst the repository. - Sets up Rust + Node tooling needed by the Socket CLI and parses scan output to emit a Tier-2 fallback warning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Install Socket CLI | ||
| run: npm install -g socket |
There was a problem hiding this comment.
Left as unpinned to include latest features/support in the CLI without needing to bump it periodically, I think pinning will add too much overhead for maintenance, probably not worth it for this kind of generic tool. (the socket API token used by the job has limited permissions to only trigger a new scan in Socket backend, so the risk of a new malicious CLI release is contained)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57e8b935e2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Make the Node 24 env-var comment date-agnostic (2026-06-16 has passed) - Remove the unused Corepack step; this repo has no package.json, so it only ever shimmed yarn/pnpm that are never invoked - Replace dtolnay/rust-toolchain with `rustup update`, matching the convention in this repo's other Rust workflows and dropping a third-party action from a security workflow Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
It is now dead config, for two independent reasons: - Every action pinned in this workflow already declares `using: node24` in its action.yml, and the var only upgrades actions that declare node20 — so it had no effect here even before the cutover. - GitHub runners have defaulted to Node 24 since 2026-06-16, and Node 20 is fully removed on 2026-09-16. Note the var never silenced the node20 deprecation warnings either: the runner classifies an action from its declared version before consulting this var (actions/runner#4295). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
More info: https://stellarorg.atlassian.net/wiki/spaces/SCRT/pages/5689311233/Socket+Tier+1+Reachability+Analysis